Skip to content

Conversation

@atharvashahane28
Copy link
Collaborator

This PR will:

Move models environment into package namespace and don't load them during package load. This is simpler than what we are doing now.

  1. In R/models.R:
    models <- new.env()

  2. In load_models():

    • Drop code that creates the environment.
    • Update conditional for loading models to only check if the models are in the environment.
  3. Delete .on_load()

  4. Add text to readme to explain that models should be explicitly loaded by calling load_models() while configuring the API.

@atharvashahane28 atharvashahane28 self-assigned this Sep 9, 2025
@atharvashahane28 atharvashahane28 linked an issue Sep 9, 2025 that may be closed by this pull request
5 tasks
@atharvashahane28 atharvashahane28 merged commit b1d7b5a into main Sep 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move models into package namespace

2 participants